Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] remove connection #8682

Merged
merged 1 commit into from
Jun 7, 2021
Merged

[tests-only] remove connection #8682

merged 1 commit into from
Jun 7, 2021

Conversation

swoichha
Copy link
Contributor

@swoichha swoichha commented Jun 4, 2021

Description

This PR adds tests for removing connection after a user has been added to the desktop-client

Related Issue

@swoichha swoichha requested a review from Talank June 4, 2021 10:28
@swoichha swoichha self-assigned this Jun 4, 2021
@swoichha swoichha force-pushed the test-user-remove branch 2 times, most recently from ad6c895 to 660cf9f Compare June 4, 2021 10:32
@swoichha swoichha requested a review from Talank June 4, 2021 11:31
Talank
Talank reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Talank Talank requested a review from individual-it June 4, 2021 11:36
individual-it
individual-it requested changes Jun 4, 2021
View reviewed changes
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/tst_removeAccount/test.feature Outdated Show resolved Hide resolved
test/gui/shared/scripts/pageObjects/AccountStatus.py Outdated Show resolved Hide resolved
individual-it
individual-it requested changes Jun 7, 2021
View reviewed changes
test/gui/shared/scripts/names.py Outdated Show resolved Hide resolved
test/gui/shared/scripts/pageObjects/Toolbar.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swoichha swoichha merged commit fe113b7 into master Jun 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-user-remove branch June 7, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@Talank Talank Talank approved these changes

Assignees

@swoichha swoichha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swoichha @individual-it @Talank